fix(search): bug with tags count on record update

roboto84 · Nov 23, 2023 · 63f1465 · 63f1465
1 parent 0b66e5d
commit 63f1465
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/src/views/search/arcadia/components/ArcResult/ArcResult.tsx b/src/views/search/arcadia/components/ArcResult/ArcResult.tsx
@@ -41,9 +41,7 @@ export function ArcResult(props: ArcResultProps) {
         { deep: true },
       );
 
-      if (state.tags.length !== camelCasedData.numberOfSubjects) {
-        dispatch({ type: SearchActionsEnum.LOAD_TAGS, value: camelCasedData.subjectsCounts });
-      }
+      dispatch({ type: SearchActionsEnum.LOAD_TAGS, value: camelCasedData.subjectsCounts });
     });
   };
 

diff --git a/...ews/search/arcadia/components/ArcResult/components/ArcResultEdit/ArcResultEditConfirm.tsx b/...ews/search/arcadia/components/ArcResult/components/ArcResultEdit/ArcResultEditConfirm.tsx
@@ -22,7 +22,6 @@ export function ArcResultEditConfirm(props: ArcResultEditConfirmProps) {
   if (!isFetching) {
     if (isError && error) {
       editResult.editingMessage = `An error has occurred editing: ${itemEditPackage.data}`;
-      onEditConfirmed(editResult);
     } else if (data) {
       const arcDeleteResult: ArcEditItemResults = camelcaseKeys<ArcEditItemResults>(
         data,
@@ -34,8 +33,9 @@ export function ArcResultEditConfirm(props: ArcResultEditConfirmProps) {
       } else {
         editResult.editingMessage = 'There was an issue with editing this record';
       }
-      onEditConfirmed(editResult);
     }
+    // TODO: Rid ourselves of the dependence on JS call stack manipulation here
+    setTimeout(() => onEditConfirmed(editResult), 0);
   }
 
   return (

diff --git a/src/views/search/components/AddRecord/AddRecord.tsx b/src/views/search/components/AddRecord/AddRecord.tsx
@@ -53,9 +53,7 @@ export function AddRecord(props: AddRecordProps) {
         { deep: true },
       );
 
-      if (state.tags.length !== camelCasedData.numberOfSubjects) {
-        dispatch({ type: SearchActionsEnum.LOAD_TAGS, value: camelCasedData.subjectsCounts });
-      }
+      dispatch({ type: SearchActionsEnum.LOAD_TAGS, value: camelCasedData.subjectsCounts });
     });
   };