Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported tag pattern: *.* #104

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Mar 31, 2024

I pushed the tag 4.12 to the upstream, but it doesn't trigger a new release automatically.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz requested review from Bencodes and hoisie March 31, 2024 02:46
@utzcoz
Copy link
Member Author

utzcoz commented Mar 31, 2024

After it merged, I decide to push a new tag called: 4.12.0.1 as a patch version of robolectric-bazel for robolectric 4.12.

@utzcoz
Copy link
Member Author

utzcoz commented Mar 31, 2024

Okay, I deleted the tag 4.12, and re-try push 4.12 tag again after this one merged. @hoisie Sorry about it.

Copy link
Collaborator

@Bencodes Bencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, did we also want to switch over to the new versioning at the same time since this offers the clean-cut that we'd need?

@utzcoz
Copy link
Member Author

utzcoz commented Mar 31, 2024

@Bencodes What do you mean? Do we need to release 4.12 with tag 4.12.0?

@utzcoz utzcoz merged commit 46b20a3 into robolectric:master Mar 31, 2024
13 checks passed
@utzcoz utzcoz deleted the more-supported-tag branch March 31, 2024 05:09
@utzcoz
Copy link
Member Author

utzcoz commented Mar 31, 2024

@Bencodes I decide to release 4.12 too. But the later patch version , we can try new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants