Simulation plugin #292
Merged
Simulation plugin #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tests are failing. 😮 |
|
Oh yeah, fixed that. Was not even related to the PR :D |
tajo
reviewed
Jun 10, 2017
| ).toEqual({ | ||
| width: 20, | ||
| backgroundColor: 'blue', | ||
| color: 'blue' |
There was a problem hiding this comment.
Why is color: blue winning over color: red? Does the order of props in const style matter? If so, it's kinda weird since object doesn't enforce order.
There was a problem hiding this comment.
In that case, I would just delete this test, since it's not necessarily deterministic.
There was a problem hiding this comment.
Yeah, right now it simply iterates all object values and resolves them straight in order. Could later improve that to first resolve medias, then pseudos, etc.
tajo
approved these changes
Jun 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.