Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instruments. #227

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Add Instruments. #227

merged 2 commits into from
Apr 18, 2020

Conversation

adithyabsk
Copy link
Member

@adithyabsk adithyabsk commented Apr 18, 2020

Checklist

  • Added tests for changed code.
  • Updated documentation for changed code.
  • I've added a news fragment of my changes with the name,
    "{ISSUE_NUM}.{feature|bugfix|doc|removal|misc}""

Related Issue

N/A

Description

  • Update models/base.py
    • Remove len from BaseModel
    • Add first BaseSchema class attribute to help filter before
      object load
    • Add BasePaginator and BasePaginatorSchema
  • models/sessionmanager.py
    • Update timeout in SessionManager
    • Add many keyword to schema load
    • Add guard for common schema error (class instead of object)
  • Add PyrhValueError, InvalidOperation, and remove InvalidInstrumentId
  • Integrate instruments with robinhood.py
  • Remove xdoctest: not quite useful since a lot of doc tests cannot be
    run.
    • Update poetry.lock

* Update models/base.py
  * Remove len from BaseModel
  * Add __first__ BaseSchema class attribute to help filter before
  object load
  * Add BasePaginator and BasePaginatorSchema
* models/sessionmanager.py
  * Update timeout in SessionManager
  * Add many keyword to schema load
  * Add guard for common schema error (class instead of object)
* Add PyrhValueError, InvalidOperation, and remove InvalidInstrumentId
* Integrate instruments with robinhood.py
* Remove xdoctest: not quite useful since a lot of doc tests cannot be
  run.
  * Update poetry.lock
@adithyabsk adithyabsk self-assigned this Apr 18, 2020
@adithyabsk adithyabsk mentioned this pull request Apr 18, 2020
3 tasks
@adithyabsk
Copy link
Member Author

Skipping adding tests because of #224 (comment)

@adithyabsk adithyabsk marked this pull request as ready for review April 18, 2020 21:11
@adithyabsk adithyabsk merged commit 0113d31 into master Apr 18, 2020
@adithyabsk adithyabsk deleted the add_instruments branch April 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant