Replace PtrLen/MutPtrLen with SrcDest for vectorized op inputs/outputs #599
+105
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vectorized operations can operate either in-place on a single mutable slice, or a pair of source and destination slices where the destination is uninitialized. To handle both cases with the same implementation, slice-like types without the aliasing guarantees were used. Replace this with a `SrcDest` type which models the possible cases better in the type system and is a step towards reducing unsafety in vectorized ops. Part of #549.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vectorized operations can operate either in-place on a single mutable slice, or a pair of source and destination slices where the destination is uninitialized. To handle both cases with the same implementation, slice-like types without the aliasing guarantees were used. Replace this with a
SrcDesttype which models the possible cases better in the type system and is a step towards reducing unsafety in vectorized ops.Part of #549.