Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/update patterns with examples #201

Merged
merged 7 commits into from
Feb 25, 2025
Merged

feature/update patterns with examples #201

merged 7 commits into from
Feb 25, 2025

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Feb 25, 2025 •
edited
Loading

PR Context

  • we need more examples for URI patterns to generate better artificial data
  • the patterns had some inconsistencies and unnecessary capture-groups in them, which is now cleaned up

Changes

  • BREAKING: update patterns for all URI-like field definitions and add more examples

Fixed

  • BREAKING: fixed patterns for year_month, concept/scheme identifier and link url

@cutoffthetop cutoffthetop requested a review from fdiehr February 25, 2025 14:39
fdiehr
fdiehr requested changes Feb 25, 2025
View reviewed changes
@cutoffthetop
fix wikidata examples
63660fd 
Signed-off-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
@cutoffthetop
Update organization.json
a914afd 
Signed-off-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
@cutoffthetop cutoffthetop merged commit 87ea64e into main Feb 25, 2025
3 checks passed
@cutoffthetop cutoffthetop deleted the feature/update-patterns-with-examples branch February 25, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdiehr fdiehr fdiehr approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @fdiehr