Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mx 1660 ldap search endpoint #294

Merged
merged 15 commits into from
Oct 1, 2024
Merged

Feature/mx 1660 ldap search endpoint #294

merged 15 commits into from
Oct 1, 2024

Conversation

vyvytranngoc
Copy link
Contributor

@vyvytranngoc vyvytranngoc commented Sep 24, 2024 •
edited
Loading

PR Context

  • LDAP search endpoint in mex-backend
  • mex-backend has a new search endpoint returning ldap persons

Added

  • extract ldap: get_persons methods and tests

Changes

Deprecated

Removed

Fixed

Security

cutoffthetop
cutoffthetop requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few clean-up suggestions

tests/ldap/test_extract.py Outdated Show resolved Hide resolved
tests/ldap/test_extract.py Outdated Show resolved Hide resolved
tests/ldap/test_extract.py Outdated Show resolved Hide resolved
mex/common/ldap/extract.py Outdated Show resolved Hide resolved
mex/common/ldap/extract.py Outdated Show resolved Hide resolved
@vyvytranngoc
Copy link
Contributor Author

ruff-linter fails. Could not comprehend which files were re-formatted. Therefore, I re-run ruff linter in .\tests\ldap and .\mex\common\ldap. But there all checks passed.

@cutoffthetop
Copy link
Contributor

ruff-linter fails. Could not comprehend which files were re-formatted. Therefore, I re-run ruff linter in .\tests\ldap and .\mex\common\ldap. But there all checks passed.

@vyvytranngoc you can run pdm lint to run all pre-commit checks and linters on all files -- this should give you the same errors / re-formatting as the pipeline

@cutoffthetop cutoffthetop merged commit d581817 into main Oct 1, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1660-ldap-search-endpoint branch October 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutoffthetop cutoffthetop cutoffthetop approved these changes

Assignees

@vyvytranngoc vyvytranngoc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyvytranngoc @cutoffthetop