Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mx 1604 wikidata extract multiple orgs #223

Merged
merged 14 commits into from
Jul 16, 2024

Conversation

mr-kamran-ali
Copy link
Contributor

PR Context

A total search results is required for frontend operations to show proper pagination. This PR implements an additional function to get just the total count. Further context in mex-backend related PR comment: robert-koch-institut/mex-backend#91 (comment)

Added

  • get count of found wikidata organizations

@mr-kamran-ali mr-kamran-ali changed the title Feature/mx 1604 wikidata extract multuple orgs Feature/mx 1604 wikidata extract multiple orgs Jul 15, 2024
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some docstring fixes needed

mex/common/wikidata/extract.py Outdated Show resolved Hide resolved
mex/common/wikidata/extract.py Outdated Show resolved Hide resolved
@cutoffthetop cutoffthetop merged commit aad788b into main Jul 16, 2024
7 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1604-wikidata-extract-multuple-orgs branch July 16, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants