-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mx 1604 wikidata extract multiple orgs #223
Merged
cutoffthetop
merged 14 commits into
main
from
feature/mx-1604-wikidata-extract-multuple-orgs
Jul 16, 2024
Merged
Feature/mx 1604 wikidata extract multiple orgs #223
cutoffthetop
merged 14 commits into
main
from
feature/mx-1604-wikidata-extract-multuple-orgs
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmon into feature/mx-1604-wikidata-extract-multuple-orgs
mr-kamran-ali
changed the title
Feature/mx 1604 wikidata extract multuple orgs
Feature/mx 1604 wikidata extract multiple orgs
Jul 15, 2024
cutoffthetop
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some docstring fixes needed
cutoffthetop
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Context
A total search results is required for frontend operations to show proper pagination. This PR implements an additional function to get just the total count. Further context in mex-backend related PR comment: robert-koch-institut/mex-backend#91 (comment)
Added