Add yield moment calculation #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbievanleeuwen
added
enhancement
TLCFEM
reviewed
Oct 31, 2024
| fy = group.material.yield_strength | ||
|
|
||
| # loop through each element in the material group | ||
| for el in group.elements: |
There was a problem hiding this comment.
Why not directly using the second moment of inertial and figure our the farthest fibre in each group, similar to elastic section modulus to figure out the yield moment for each group?
Looping over all elements seems to be very slow when the mesh is fine.
Reusing existing information may be beneficial here.
TLCFEM
reviewed
Oct 31, 2024
| x11, y22 = fea.principal_coordinate(phi=phi, x=x, y=y) | ||
|
|
||
| # calculate bending stresses due to unit moments | ||
| sig_mxx = em * ( |
There was a problem hiding this comment.
This part is pure numerical, can be jit-ed to improve performance.
TLCFEM
reviewed
Oct 31, 2024
| sig_m22 = -em / i22 * x11 | ||
|
|
||
| # update yield indexes | ||
| yield_index["mxx"] = max(yield_index["mxx"], abs(sig_mxx / fy)) |
There was a problem hiding this comment.
This one is minor, why not directly store: yield_moment=min(yield_moment,abs(fy/sig_m))?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #232.