Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift package manager #706

Merged
merged 7 commits into from
Feb 17, 2020
Merged

Swift package manager #706

merged 7 commits into from
Feb 17, 2020

Conversation

RockLobster
Copy link

Adding support for the swift package manager

@chrisballinger
Copy link
Collaborator

@RockLobster Thanks! Can you add a swift build step to the .travis.yml?

@RockLobster
Copy link
Author

Good one, will do!

@chrisballinger
Copy link
Collaborator

Looks like the tests might need to be updated:

❌ /Users/travis/build/robbiehanson/CocoaAsyncSocket/Tests/Shared/SwiftTests.swift:164:38: overlapping accesses to 'addr', but modification requires exclusive access; consider copying to a local variable
742
743 withUnsafeMutablePointer(to: &addr) {

@RockLobster
Copy link
Author

Yeah, it seems that the tests don’t run on Xcode 11 and the old CI was still run on Xcode 9.
I’ll see what I can do

@chrisballinger
Copy link
Collaborator

@RockLobster Thank you for looking into it!

@RockLobster
Copy link
Author

RockLobster commented Feb 17, 2020

I now also added the shared unit tests to SPM, did increase the size of the PR slightly, though.

Main reason for the size increase is because SPM does not support targets that mix and match between objc and swift.
By putting the swift and objc test code into separate directories that can be easily solved by using two separate test targets.

Copy link
Collaborator

@chrisballinger chrisballinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RockLobster Awesome job, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants