Minor features (NSNetService and nullability fixes) #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisballinger @jakebromberg @jdeff @zhouzhongguang as you've all committed to this project recently, perhaps you'd care to review this too? |
| @@ -656,7 +662,7 @@ typedef NS_ENUM(NSInteger, GCDAsyncSocketError) { | |||
| * completes writing the bytes (which is NOT immediately after this method returns, but rather at a later time | |||
| * when the delegate method notifies you), then you should first copy the bytes, and pass the copy to this method. | |||
| **/ | |||
| - (void)writeData:(NSData *)data withTimeout:(NSTimeInterval)timeout tag:(long)tag; | |||
| - (void)writeData:(nullable NSData *)data withTimeout:(NSTimeInterval)timeout tag:(long)tag; | |||
There was a problem hiding this comment.
When would it be valid to pass nil data here?
There was a problem hiding this comment.
I made it nullable to conform to the docs, line 651: "If you pass in nil or zero-length data, this method does nothing and the delegate will not be called." There could be code out there relying on this.
There was a problem hiding this comment.
I'm ok with reverting it to nonnull and changing the docs if you'd prefer...
readDataToData: and writeData: are documented to accept nil data and indeed behave as documented, therefore make the parameter nullable as some users may already rely on this behaviour.
NSURL path can return nil, but fileExistsAtPath: can't accept nil, so the compiler was warning, even though this would never likely happen in practice. Added nil check.
chrisballinger
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are not as trivial as my last PR, but still pretty straightforward.