Algorithm.Sign() was pre-encoding the signature; the rest of the lib then double encoded them #18

henderjon · 2018-02-22T21:02:20Z

Externally created tokens were failing to validate, it turns out that signatures were being double encoded.

I used the debugger at jwt.io to confirm.

… signatures were being double encoded. I used the debugger at jwt.io to confirm.

coveralls · 2018-02-22T21:04:11Z

Coverage remained the same at 75.238% when pulling 2479b53 on henderjon:master into 0c02049 on robbert229:master.

yedpodtrzitko · 2018-03-01T20:53:30Z

can confirm this issue

henderjon added 2 commits February 22, 2018 14:18

adds a test to validate a token generated externally

c702dd3

Externally created tokens were failing to vaildate, it turns out that…

2479b53

… signatures were being double encoded. I used the debugger at jwt.io to confirm.

robbert229 merged commit 81ddea8 into robbert229:master Mar 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Algorithm.Sign() was pre-encoding the signature; the rest of the lib then double encoded them #18

Algorithm.Sign() was pre-encoding the signature; the rest of the lib then double encoded them #18

henderjon commented Feb 22, 2018 •

edited

Loading

coveralls commented Feb 22, 2018

yedpodtrzitko commented Mar 1, 2018

Algorithm.Sign() was pre-encoding the signature; the rest of the lib then double encoded them #18

Algorithm.Sign() was pre-encoding the signature; the rest of the lib then double encoded them #18

Conversation

henderjon commented Feb 22, 2018 • edited Loading

coveralls commented Feb 22, 2018

yedpodtrzitko commented Mar 1, 2018

henderjon commented Feb 22, 2018 •

edited

Loading