check-es-compat: Disallowed Eslint inline config comments to work with unminified code. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've now removed the Node 14 build check gate, as the actual build configuration was removed previously. |
|
This change does remove the option for CLI users to disable this plugin. The reporter of #47 was doing this as a workaround (last sentence of the issue description). But they weren't using CLI. I think this is fine. From a CLI tool perspective it shouldn't even be visible that ESLint is used under the hood. |
robatwilliams
approved these changes
Mar 7, 2024
agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100