Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove a todo comment from the tracing mod #343

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

spencewenski
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.88%. Comparing base (8383651) to head (e10a6ca).
Report is 1 commits behind head on main.

Files Patch % Lines
src/tracing/mod.rs 0.00% 12 Missing ⚠️
Files Coverage Δ
src/tracing/mod.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8383651...e10a6ca. Read the comment docs.

@spencewenski spencewenski merged commit 1aca731 into main Aug 20, 2024
14 of 15 checks passed
@spencewenski spencewenski deleted the remove-todo branch August 20, 2024 00:58
This was referenced Aug 23, 2024
spencewenski added a commit that referenced this pull request Aug 26, 2024
## 🤖 New release
* `roadster`: 0.5.19 -> 0.6.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.6.0](roadster-v0.5.19...roadster-v0.6.0)
- 2024-08-25

### Added
- Add a public method to decode a JWT from a string
([#348](#348))
- Mark refresh token headers as sensitive
([#347](#347))
- Make the `User` sea-orm migration enum public
([#346](#346))
- Allow splitting config files into many files in env directories
([#344](#344))
- [**breaking**] App methods take `self`
([#337](#337))
- Remove cookie extraction for `Jwt`, but allow it in `JwtCsrf`
([#332](#332))
- Allow custom sub-claims in provided `Claims` types
([#331](#331))
- Allow jwt from cookie, but only if it's explicitly requested
([#329](#329))

### Fixed
- [**breaking**] Don't expect a "Bearer" token in the auth token cookie
([#340](#340))

### Other
- Remove a `todo` comment
([#345](#345))
- Remove a todo comment from the tracing mod
([#343](#343))
- Update leptos example to use site-addr and env from roadster config
([#341](#341))
- sea-orm workspace dep and upgrade to `1.0.0`
([#336](#336))
- [**breaking**] Update tower to `0.5.0`
([#334](#334))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant