Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add support for ErrorVisibilityTimeout and job retention #571

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feature: add support for ErrorVisibilityTimeout and job retention #571

wants to merge 12 commits into from

Commits on Oct 24, 2024

  1. Remove invalid prefetch value in test files (max is 10 on SQS) 

    Remove unused PHP test files and cleaned op the remaining ones
Added options error_visibility_timeout and retain_failed_jobs to SQS driver
Locked opentelemetry docker image to a version that works with tests
Created common method for Nack to deduplicate code
Adjusted durability test from GreaterThan to Equal
Fixed wrong order of expected vs. actual param in some tests
    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    13057cf View commit details
    Browse the repository at this point in the history

  2. Log and ignore MessageNotInflight error for ChangeMessageVisibility

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1a86abc View commit details
    Browse the repository at this point in the history

  3. Add validation to timeout 

    Fix yaml newline
Reword some comments
    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6b0a683 View commit details
    Browse the repository at this point in the history

  4. Fix otel deprecation; remove version lock

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fd060de View commit details
    Browse the repository at this point in the history

  5. Remove extra space

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8477f6c View commit details
    Browse the repository at this point in the history

  6. Make commonNack private, fix order of calls to i.Options.stopped 

    Make reused error string a constant
    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b1da4ab View commit details
    Browse the repository at this point in the history

  7. Add missing newline to .yml conf

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    97d32bc View commit details
    Browse the repository at this point in the history

  8. Correctly name error constant/message

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7f5614b View commit details
    Browse the repository at this point in the history

  9. rename err alias

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fa221e8 View commit details
    Browse the repository at this point in the history

  10. Fix commonNack logic to retain original functionality 

    Adjust error message
change if-else to switch
    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cf36b16 View commit details
    Browse the repository at this point in the history

  11. Adjust test timeouts for error visibility

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bbd92e1 View commit details
    Browse the repository at this point in the history

  12. use different rpc port for sqs tests

    @nickdnk
    nickdnk committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ca95599 View commit details
    Browse the repository at this point in the history