Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

feature: enhance CORS support #140

Merged
merged 1 commit into from
Jun 21, 2023
Merged

feature: enhance CORS support #140

merged 1 commit into from
Jun 21, 2023

Conversation

rmikalkenas
Copy link
Contributor

No description provided.

@rustatian
Copy link
Member

Hey @rmikalkenas 👋🏻
Awesome, thanks for the PR 👍🏻
I also added a new option called debug to debug CORS requests/responses. This is separate option since I can't pass RR logger to the CORS library: https://github.com/roadrunner-server/headers/blob/master/config.go#L32
Could you please add it as well?
I also slightly updated your merged PR, you may have a look at the changes here: roadrunner-server/headers@dc73b7a

@rmikalkenas
Copy link
Contributor Author

Hey @rmikalkenas 👋🏻 Awesome, thanks for the PR 👍🏻 I also added a new option called debug to debug CORS requests/responses. This is separate option since I can't pass RR logger to the CORS library: https://github.com/roadrunner-server/headers/blob/master/config.go#L32 Could you please add it as well? I also slightly updated your merged PR, you may have a look at the changes here: roadrunner-server/headers@dc73b7a

Great addition 🎉 updated the PR 👍

Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rmikalkenas 👍🏻

@rustatian rustatian merged commit d593976 into roadrunner-server:2023.x Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants