Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update httpV1Beta proto #61

Merged
merged 10 commits into from
Mar 28, 2024
Merged

chore: update httpV1Beta proto #61

merged 10 commits into from
Mar 28, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Mar 12, 2024

Reason for This PR

  • HTTP proto bridge

Description of Changes

  • Update Message type. Use oneof to send the payload.
  • Update Request message, replace map<...> with Header type.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • New Features
    • Introduced a new protocol buffer definition for enhanced HTTP communication, including comprehensive structures for requests, responses, and headers.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. P-HTTP Plugin: HTTP labels Mar 12, 2024
@rustatian rustatian requested a review from wolfy-j March 12, 2024 13:04
@rustatian rustatian self-assigned this Mar 12, 2024
Copy link

coderabbitai bot commented Mar 12, 2024

Walkthrough

The recent update introduces a protocol buffer definition for handling HTTP requests and responses, encapsulated within version 1. This new definition outlines the structure for various components such as Requests, Responses, and their Headers, including specifics like method, status, and headers. It's designed to streamline HTTP communication by providing a clear framework for the exchange of information between clients and servers.

Changes

File Path Change Summary
proto/http/v1/... Introduced protocol buffer definitions for HTTP Requests, Responses, Headers, and HeaderValues.

Poem

🐇
In the digital meadow, under the byte-sized sun,
A new protocol blooms, its journey just begun.
Requests and responses, in harmony they dance,
With headers and methods, they advance.
🌼
Through the network's burrow, swift and keen,
A rabbit celebrates, unseen.
"To HTTP's future," it whispers with glee,
"May your data flow, free and easy."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian marked this pull request as ready for review March 28, 2024 16:36
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 09fc01b and 4b0a3e4.
Files ignored due to path filters (4)
  • build/http/v1/http.pb.go is excluded by !**/*.pb.go
  • build/http/v1beta/http.pb.go is excluded by !**/*.pb.go
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • proto/http/v1/http.proto (1 hunks)
Additional comments (2)
proto/http/v1/http.proto (2)
  • 25-27: The Header message type is introduced but not utilized within the Request or Response messages. Consider integrating the Header message into these messages to enhance the structure and organization of headers, aligning with the PR's objectives.
  • 34-36: The HeaderValue message structure, allowing for multiple values per header, is well-designed and correctly implemented. This approach is suitable for representing HTTP headers that can have multiple values.

@rustatian rustatian merged commit 21d8e3b into master Mar 28, 2024
@rustatian rustatian deleted the feat/updated-http-proto branch March 28, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. P-HTTP Plugin: HTTP
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant