Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Factory::isAvailable method as deprecated. #26

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

butschster
Copy link
Contributor

@butschster butschster commented Aug 22, 2022

Since RoadRunner version 2.3 there is not an ability to get list of available plugins via RPC and every time when developers started using this package they bumped into a problem with Factory::isAvailable method. With this PR the method was marked as a deprecated and now it will throw an exception with information about deprecation.

@butschster butschster added the B-bug Bug: bug, exception label Aug 22, 2022
@butschster butschster self-assigned this Aug 22, 2022
Copy link
Contributor

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@butschster butschster requested a review from msmakouz August 22, 2022 14:43
@butschster butschster merged commit 22d0cf0 into master Aug 22, 2022
@butschster butschster linked an issue Aug 22, 2022 that may be closed by this pull request
@butschster butschster deleted the fix/deprecate-method branch September 24, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC started with kv but it not available from code
3 participants