deleted $this->complete(); from __destruct #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#8 |
butschster
reviewed
Nov 26, 2021
src/Task/ReceivedTask.php
Outdated
| @@ -69,15 +69,7 @@ public function __construct( | |||
| */ | |||
| public function __destruct() | |||
There was a problem hiding this comment.
you mean it's redundant, need to be deleted?
There was a problem hiding this comment.
@butschster could provide the release tag for it, pls. I want to update my deps
…ge behavior when the php object should be destroyed.
sergey-telpuk
force-pushed
the
Bug_Job_ReceivedTask_Retry_task_dosent_work_properly
branch
from
452412b to
8263e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.