Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: AMQP queue headers #59

Merged

Conversation

danilin-em
Copy link
Contributor

Feature: roadrunner-php/issues#22

Declare AMQP Queue headers

// ...
'connector' => new AMQPCreateInfo(
    // ...
    queueHeaders: [
        'x-queue-type' => 'quorum',
        'x-dead-letter-exchange' => 'jobs-dlx',
    ],
),
// ...

@butschster butschster self-requested a review October 6, 2023 09:22
@butschster butschster added the enhancement New feature or request label Oct 6, 2023
@butschster butschster self-assigned this Oct 6, 2023
@butschster butschster added this to the 4.x milestone Oct 6, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9185d6c) 86.52% compared to head (7043283) 86.56%.
Report is 2 commits behind head on 4.x.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x      #59      +/-   ##
============================================
+ Coverage     86.52%   86.56%   +0.03%     
  Complexity      191      191              
============================================
  Files            29       30       +1     
  Lines           579      588       +9     
============================================
+ Hits            501      509       +8     
- Misses           78       79       +1     
Files Coverage Δ
src/Jobs.php 96.66% <100.00%> (+0.44%) ⬆️
src/Queue/AMQPCreateInfo.php 100.00% <100.00%> (ø)
src/Queue/AMQP/Header.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit d031e96 into roadrunner-php:4.x Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants