Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RR jobs plugin requires string map #20

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

rauanmayemir
Copy link
Contributor

This solves an issue when you pass ->withHeader('header_name', 1) and it breaks RR jobs plugin.

This solves an issue when you pass `->withHeader('header_name', 1)` and it breaks RR jobs plugin.
@butschster butschster self-requested a review July 11, 2022 07:07
@butschster butschster self-assigned this Jul 11, 2022
@butschster butschster added the bug Something isn't working label Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #20 (494c54e) into master (0a0f1d5) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     40.00%   40.00%           
  Complexity      171      171           
=========================================
  Files            19       19           
  Lines           505      505           
=========================================
  Hits            202      202           
  Misses          303      303           
Impacted Files Coverage Δ
src/Task/WritableHeadersTrait.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0f1d5...494c54e. Read the comment docs.

@butschster butschster merged commit abad228 into roadrunner-php:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants