chore: PHPstan fixes

roadiz · Mar 8, 2024 · e96a763 · e96a763
1 parent 16201fe
commit e96a763
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/lib/EntityGenerator/src/Attribute/AttributeGenerator.php b/lib/EntityGenerator/src/Attribute/AttributeGenerator.php
@@ -14,7 +14,7 @@ class AttributeGenerator
 
     /**
      * @param string $className
-     * @param array<string|int, string|int|array> $parameters
+     * @param array<string|int, string|int|array|null> $parameters
      */
     public function __construct(string $className, array $parameters = [])
     {

diff --git a/lib/EntityGenerator/src/Field/AbstractFieldGenerator.php b/lib/EntityGenerator/src/Field/AbstractFieldGenerator.php
@@ -155,8 +155,8 @@ protected function getFieldAttributes(bool $exclude = false): array
             if (!empty($this->field->getDescription())) {
                 $description .= ': ' . $this->field->getDescription();
             }
-            if ($this->field->isEnum()) {
-                $enumValues = explode(',', $this->field->getDefaultValues());
+            if ($this->field->isEnum() && null !== $defaultValues = $this->field->getDefaultValues()) {
+                $enumValues = explode(',', $defaultValues);
                 $enumValues = array_filter(array_map('trim', $enumValues));
                 $openapiContext = [
                     'type' => 'string',

diff --git a/lib/OpenId/src/Authentication/OpenIdAuthenticator.php b/lib/OpenId/src/Authentication/OpenIdAuthenticator.php
@@ -22,14 +22,13 @@
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
-use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\Security\Core\User\UserInterface;
-use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Symfony\Component\Security\Http\Authenticator\AbstractAuthenticator;
 use Symfony\Component\Security\Http\Authenticator\Passport\Badge\UserBadge;
 use Symfony\Component\Security\Http\Authenticator\Passport\Credentials\CustomCredentials;
 use Symfony\Component\Security\Http\Authenticator\Passport\Passport;
 use Symfony\Component\Security\Http\HttpUtils;
+use Symfony\Component\Security\Http\SecurityRequestAttributes;
 use Symfony\Component\Security\Http\Util\TargetPathTrait;
 
 final class OpenIdAuthenticator extends AbstractAuthenticator
@@ -274,7 +273,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,
     public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
     {
         if ($request->hasSession()) {
-            $request->getSession()->set(Security::AUTHENTICATION_ERROR, $exception);
+            $request->getSession()->set(SecurityRequestAttributes::AUTHENTICATION_ERROR, $exception);
         }
         $url = $this->urlGenerator->generate($this->defaultRoute);
 

diff --git a/lib/RoadizRozierBundle/src/Controller/Node/RealmNodeController.php b/lib/RoadizRozierBundle/src/Controller/Node/RealmNodeController.php
@@ -116,9 +116,7 @@ public function deleteAction(Request $request, int $id, int $realmNodeId): Respo
                 'node.%node%.left.%realm%',
                 [
                     '%node%' => $nodeSource->getTitle(),
-                    '%realm%' => $realmNode->getRealm() ?
-                        $realmNode->getRealm()->getName() :
-                        $this->translator->trans('node.no_realm')
+                    '%realm%' => $realmNode->getRealm()->getName()
                 ]
             );
             $this->publishConfirmMessage($request, $msg);