feat: Rename getCompositeIdentifier to getIdempotentIdentifier and pr…

…ovided a fallback.

BREAKING CHANGE: All Solr documents MUST have a idempotent ID field to ease up Solr indexing (no more need to delete previous index entry before indexing an entity).

lib/RoadizCoreBundle/src/SearchEngine/AbstractSolarium.php

@@ -196,7 +196,7 @@ public function cleanAndCommit(): void
     public function index(): bool
     {
         if ($this->document instanceof Document) {
-            $this->document->setKey('id', $this->getCompositeIdentifier());
+            $this->document->setKey('id', $this->getIdempotentIdentifier());
 
             try {
                 foreach ($this->getFieldsAssoc() as $key => $value) {
@@ -310,5 +310,15 @@ public function cleanTextContent(?string $content, bool $stripMarkdown = true):
         return $content;
     }
 
-    abstract protected function getCompositeIdentifier(): string;
+    /**
+     * You MUST override this method to provide an idempotent identifier.
+     * This identifier MUST be the same for the same entity.
+     *
+     * @return string
+     */
+    protected function getIdempotentIdentifier(): string
+    {
+        // This is a fallback for backward compatibility.
+        return uniqid('', true);
+    }
 }

lib/RoadizCoreBundle/src/SearchEngine/SolariumDocument.php

@@ -206,7 +206,7 @@ public function index(): bool
         return true;
     }
 
-    protected function getCompositeIdentifier(): string
+    protected function getIdempotentIdentifier(): string
     {
         throw new \InvalidArgumentException('SolariumDocument should not provide any ID');
     }

lib/RoadizCoreBundle/src/SearchEngine/SolariumDocumentTranslation.php

@@ -67,7 +67,7 @@ public function clean(Query $update): bool
         return true;
     }
 
-    protected function getCompositeIdentifier(): string
+    protected function getIdempotentIdentifier(): string
     {
         $namespace = explode('\\', get_class($this->documentTranslation));
         // get last 3 parts of namespace

lib/RoadizCoreBundle/src/SearchEngine/SolariumNodeSource.php

@@ -72,7 +72,7 @@ public function clean(Query $update): bool
         return true;
     }
 
-    protected function getCompositeIdentifier(): string
+    protected function getIdempotentIdentifier(): string
     {
         $namespace = explode('\\', get_class($this->nodeSource));
         // get last 3 parts of namespace