Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint2 #2

Open
wants to merge 42 commits into
base: checkpoint1
Choose a base branch
from
Open

Checkpoint2 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
7687460
Set up cpack and version number.
rnburn Jun 9, 2017
9e83d77
Make NoopSpan constructor explicit.
rnburn Jun 10, 2017
7585a62
Add additional noexcept specifiers.
rnburn Jun 10, 2017
026c214
Change return type for BaggageItem.
rnburn Jun 10, 2017
fe3f89f
Don't include StringRef as a Value type.
rnburn Jun 10, 2017
49318d5
Cast durations when setting timestamps from epoch.
rnburn Jun 11, 2017
19ee9f1
Fix namespace issue.
rnburn Jun 12, 2017
67deb64
Rewrite constructors for Value type.
rnburn Jun 12, 2017
57b1da8
Rewrote the error handling interface.
rnburn Jun 13, 2017
d103e34
Added HTTPCarrier classes.
rnburn Jun 13, 2017
133a0a8
Use pointer instead of references for ChildOf/FollowsFrom functions.
rnburn Jun 13, 2017
2e19d8e
Added header file for versioning.
rnburn Jun 14, 2017
270eb30
Allow the Foreach functor to return an error.
rnburn Jun 14, 2017
b13d7f4
Correct time_point bug.
rnburn Jun 15, 2017
3f8f218
Support different native durations in convert_time_point.
rnburn Jun 15, 2017
0fe9cee
Correction for time specification using epoch.
rnburn Jun 15, 2017
f961c79
Correct permissions in Carrier classes.
rnburn Jun 15, 2017
14d9471
Temporary work-around to https://github.com/martinmoene/expected-lite…
rnburn Jun 15, 2017
9942fca
Added equality operators to StringRef.
rnburn Jun 15, 2017
0c9500d
Added begin/end functions to StringRef.
rnburn Jun 16, 2017
5bca4fe
Support specification of StartTime with SystemClock::time_point.
rnburn Jun 16, 2017
6469ffd
Added a logging interface.
rnburn Jun 16, 2017
bb6be92
Exclude 3rd_party code from clang-format.
rnburn Jun 16, 2017
10793fb
Add a Close method to Tracer.
rnburn Jun 16, 2017
843ba18
Require a Span's destructor to call finish if not done so already.
rnburn Jun 16, 2017
3de9ab8
Fix specification of FinishTimestamp.
rnburn Jun 16, 2017
31c209e
Convert timestamp to steady clock in FinishTimestamp.
rnburn Jun 16, 2017
8d02ac5
Use CMAKE_CXX_STANDARD instead of setting CMAKE_CXX_FLAGS.
rnburn Jun 16, 2017
cd1f27b
Set up clang-tidy to run with build.
rnburn Jun 16, 2017
5dc5af0
Use macros for opening and closing the inline namespace.
rnburn Jun 16, 2017
042c15c
Fix namespace comment.
rnburn Jun 16, 2017
4df0a78
Correct clang-tidy warnings.
rnburn Jun 16, 2017
36d3eb4
s/reset/Reset/g
rnburn Jun 16, 2017
67ef435
Correction in README.md.
rnburn Jun 17, 2017
c98410b
Update 3rd party expected library.
rnburn Jun 17, 2017
65f6978
Add a test for convert_time_point.
rnburn Jun 17, 2017
1346d0a
Check for null in noop_test.
rnburn Jun 17, 2017
19a73e2
Added test for StartSpanOptions.
rnburn Jun 18, 2017
a5654fc
Corrected the propagation examples.
rnburn Jun 21, 2017
0b7eaec
Removed the argument from Inject/Extract.
rnburn Jun 22, 2017
3bd4c3d
Remove unsupported_format_error.
rnburn Jun 22, 2017
681eff8
Changed StringRef's API to more closely match std::string_view.
rnburn Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,16 @@ enable_testing()

project(opentracing-cpp)

set(OPENTRACING_ABI_VERSION "1")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are "set" and "SET" the same?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, cmake commands aren't case sensitive. I was also considering maybe setting the abi version from the major and minor versions.


SET(CPACK_PACKAGE_DESCRIPTION_SUMMARY "C++ implementation of the OpenTracing API")
SET(CPACK_PACKAGE_VENDOR "opentracing.io")
SET(CPACK_PACKAGE_DESCRIPTION_FILE "${CMAKE_CURRENT_SOURCE_DIR}/README.md")
SET(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE")

SET(CPACK_PACKAGE_VERSION_MAJOR "1")
SET(CPACK_PACKAGE_VERSION_MINOR "0")
SET(CPACK_PACKAGE_VERSION_PATCH "0")
include(cpack)

add_subdirectory(c++11)
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ reference.
auto tracer = /* Some Tracer */
auto span = tracer->StartSpan(
"operation_name",
{opentracing::ChildOf(parent_span.context())});
{opentracing::ChildOf(&parent_span.context())});
if (!span)
// Error creating span.
...
Expand Down
Loading