forked from opentracing/opentracing-cpp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint2 #2
Open
rnburn
wants to merge
42
commits into
checkpoint1
Choose a base branch
from
checkpoint2
base: checkpoint1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Checkpoint2 #2
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
7687460
Set up cpack and version number.
rnburn 9e83d77
Make NoopSpan constructor explicit.
rnburn 7585a62
Add additional noexcept specifiers.
rnburn 026c214
Change return type for BaggageItem.
rnburn fe3f89f
Don't include StringRef as a Value type.
rnburn 49318d5
Cast durations when setting timestamps from epoch.
rnburn 19ee9f1
Fix namespace issue.
rnburn 67deb64
Rewrite constructors for Value type.
rnburn 57b1da8
Rewrote the error handling interface.
rnburn d103e34
Added HTTPCarrier classes.
rnburn 133a0a8
Use pointer instead of references for ChildOf/FollowsFrom functions.
rnburn 2e19d8e
Added header file for versioning.
rnburn 270eb30
Allow the Foreach functor to return an error.
rnburn b13d7f4
Correct time_point bug.
rnburn 3f8f218
Support different native durations in convert_time_point.
rnburn 0fe9cee
Correction for time specification using epoch.
rnburn f961c79
Correct permissions in Carrier classes.
rnburn 14d9471
Temporary work-around to https://github.com/martinmoene/expected-lite…
rnburn 9942fca
Added equality operators to StringRef.
rnburn 0c9500d
Added begin/end functions to StringRef.
rnburn 5bca4fe
Support specification of StartTime with SystemClock::time_point.
rnburn 6469ffd
Added a logging interface.
rnburn bb6be92
Exclude 3rd_party code from clang-format.
rnburn 10793fb
Add a Close method to Tracer.
rnburn 843ba18
Require a Span's destructor to call finish if not done so already.
rnburn 3de9ab8
Fix specification of FinishTimestamp.
rnburn 31c209e
Convert timestamp to steady clock in FinishTimestamp.
rnburn 8d02ac5
Use CMAKE_CXX_STANDARD instead of setting CMAKE_CXX_FLAGS.
rnburn cd1f27b
Set up clang-tidy to run with build.
rnburn 5dc5af0
Use macros for opening and closing the inline namespace.
rnburn 042c15c
Fix namespace comment.
rnburn 4df0a78
Correct clang-tidy warnings.
rnburn 36d3eb4
s/reset/Reset/g
rnburn 67ef435
Correction in README.md.
rnburn c98410b
Update 3rd party expected library.
rnburn 65f6978
Add a test for convert_time_point.
rnburn 1346d0a
Check for null in noop_test.
rnburn 19a73e2
Added test for StartSpanOptions.
rnburn a5654fc
Corrected the propagation examples.
rnburn 0b7eaec
Removed the argument from Inject/Extract.
rnburn 3bd4c3d
Remove unsupported_format_error.
rnburn 681eff8
Changed StringRef's API to more closely match std::string_view.
rnburn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are "set" and "SET" the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, cmake commands aren't case sensitive. I was also considering maybe setting the abi version from the major and minor versions.