Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: day 21 #27

Merged
merged 5 commits into from
Dec 23, 2024
Merged

feat: day 21 #27

merged 5 commits into from
Dec 23, 2024

Conversation

rnbguy
Copy link
Owner

@rnbguy rnbguy commented Dec 22, 2024

@rnbguy rnbguy requested a review from Copilot December 22, 2024 07:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • day21/deno.json: Language not supported
  • day21/example.txt: Language not supported
Comments suppressed due to low confidence (2)

day21/test.ts:4

  • [nitpick] Add more test cases to ensure comprehensive test coverage, including edge cases.
Deno.test(async function testExample() {

day21/mod.ts:168

  • Accessing the shortestKeystrokes map without checking if the key exists could lead to a runtime error. Ensure that the key exists in the shortestKeystrokes map before accessing its values.
const keystrokes = shortestKeystrokes.get(line.join(""))!.values().reduce(

day21/mod.ts Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

github-actions bot commented Dec 22, 2024

LCOV of commit 25a1f33 during CI #61

Summary coverage rate:
  lines......: 84.7% (1825 of 2155 lines)
  functions..: 96.2% (151 of 157 functions)
  branches...: 90.1% (438 of 486 branches)

Files changed coverage rate: n/a

@rnbguy rnbguy requested a review from Copilot December 23, 2024 17:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • day21/deno.json: Language not supported
  • day21/example.txt: Language not supported
@rnbguy rnbguy merged commit 5047e02 into main Dec 23, 2024
3 checks passed
@rnbguy rnbguy deleted the day21 branch December 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant