Skip to content

Commit

Permalink
update news and cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kriemo committed May 16, 2023
1 parent e39efc3 commit 547d4ce
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 29 deletions.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

* `bed_closest()` now reports all x intervals, even when there are no closest y intervals (e.g. when there is no matching chromosome in y intervals). These intervals are returned populated with `NA` for `.overlap`, `.dist` and y interval locations.

* Reimplemented `bed_closest()` to use binary search rather than interval tree. The closest y interval can be missed with previous search strategy in high depth interval trees.
* Reimplemented `bed_closest()` to use binary search rather than an interval tree search. The closest y interval can be missed with the previous search strategy in high depth interval trees.

* Fix off by one error when using `max_dist` argument in `bed_cluster()` (#401).

Expand Down
48 changes: 20 additions & 28 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,58 +1,50 @@
## New patch version

* This is a new patch version that fixes a minor bug in the bed_coverage() function, and removes C++11 specifications from the `SystemRequirements` field and Makevar files.
* This is a new patch version, with a re-implementation of the C++ internals for `bed_closest()`, and a minor bug fix in `bed_cluster()`.

## Test environment

* win-builder (R-devel)
* local OS X install, (4.2.2)
* Windows (on Github Actions), 4.2.2 (2022-10-31 ucrt)
* macOS (on Github Actions), R 4.2.2
* ubuntu 22.04.1 (on Github Actions), (devel and R 4.2.2)
* win-builder, R devel
* macOS (local install), R 4.3.0
* Windows (on Github Actions), R 4.3.0
* macOS (on Github Actions), R 4.3.0
* ubuntu 22.04.1 (on Github Actions), R devel and 4.3.0

## R CMD check results

* on win-builder (devel)
* on Windows (win-builder, devel)

Status: 1 NOTE
0 errors | 0 warnings | 1 note

* checking CRAN incoming feasibility ... [18s] NOTE
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Kent Riemondy <kent.riemondy@cuanschutz.edu>'

Version contains large components (0.6.6.9000)

* on windows github actions (R 4.2.2)
Version contains large components (0.6.7.9000)

0 errors | 0 warnings | 0 notes
* on Windows (4.3.0)

* on OS X (R 4.2.2 and devel)
Status: OK
0 errors | 0 warnings | 0 notes

* on OS X (R 4.3.0)

Status: OK
0 errors | 0 warnings | 0 notes

* on ubuntu (devel)

Status: 1 NOTE

* checking installed package size ... NOTE
installed size is 14.2Mb
installed size is 14.5Mb
sub-directories of 1Mb or more:
libs 13.0Mb

- This package uses Rcpp, which creates a large shared library on linux.

* on ubuntu (R 4.2.2)
libs 13.3Mb

* on ubuntu (R 4.3.0)

Status: 1 NOTE

* checking installed package size ... NOTE
installed size is 14.2Mb
installed size is 14.5Mb
sub-directories of 1Mb or more:
libs 13.0Mb

- This package uses Rcpp, which creates a large shared library on linux.

libs 13.3Mb

## Reverse dependencies

Expand Down

0 comments on commit 547d4ce

Please sign in to comment.