Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update equipped field in NftInfo #238

Merged
merged 8 commits into from
Nov 22, 2022
Merged

Update equipped field in NftInfo #238

merged 8 commits into from
Nov 22, 2022

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Oct 31, 2022

Closes: #184

@Szegoo Szegoo marked this pull request as draft October 31, 2022 10:57
@Szegoo Szegoo marked this pull request as ready for review October 31, 2022 17:01
@Szegoo
Copy link
Contributor Author

Szegoo commented Oct 31, 2022

@mrshiposha PTAL.

@ilionic ilionic requested review from bmacer and HashWarlock November 1, 2022 09:23
ilionic
ilionic approved these changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@ilionic ilionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.
What about integration tests, no changes needed?

@Szegoo
Copy link
Contributor Author

Szegoo commented Nov 6, 2022 •
edited
Loading

What about integration tests, no changes needed?

I did update the integration tests so that they work now with the updated field.

@ilionic I could update the equipNft function in the integration tests so that it checks for the resource and slot id. I think that would make sense.

@ilionic
Copy link
Contributor

ilionic commented Nov 6, 2022

@Szegoo Yes, that would be great, thanks.

ilionic
ilionic reviewed Nov 11, 2022
View reviewed changes
tests/src/equipNft.test.ts Outdated Show resolved Hide resolved
@ilionic ilionic merged commit 6c695c3 into rmrk-team:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilionic ilionic ilionic approved these changes

@bmacer bmacer Awaiting requested review from bmacer

@HashWarlock HashWarlock Awaiting requested review from HashWarlock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT info struct should contain a link to an equipper
2 participants
@Szegoo @ilionic