Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equippables addition/removal feature #234

Merged
merged 9 commits into from
Nov 1, 2022
Merged

Equippables addition/removal feature #234

merged 9 commits into from
Nov 1, 2022

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Oct 21, 2022

Closes: #97

@Szegoo Szegoo marked this pull request as ready for review October 21, 2022 16:51
@Szegoo
Copy link
Contributor Author

Szegoo commented Oct 21, 2022

@bmacer PTAL.

bmacer
bmacer reviewed Oct 21, 2022
View reviewed changes
traits/src/base.rs Outdated Show resolved Hide resolved
bmacer
bmacer suggested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@bmacer bmacer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, just the ty naming is a little meh.

One consideration, this only allows for adding or removing one collection at a time. Would it be important/necessary to allow a bounded list of collections to add/remove in batches? @ilionic

@ilionic
Copy link
Contributor

ilionic commented Oct 21, 2022

@bmacer not important / necessary to add in batches. So all good.
One improvement @Szegoo if you are comfortable with Typescript and Polkadot js is to add integration test in /tests folder.
But it's optional.

@Szegoo
Copy link
Contributor Author

Szegoo commented Oct 21, 2022

@ilionic Sure I will do that.

Szegoo
Szegoo commented Oct 22, 2022
View reviewed changes
tests/src/util/tx.ts Outdated Show resolved Hide resolved
@Szegoo Szegoo requested a review from bmacer October 22, 2022 08:31
@Szegoo
Copy link
Contributor Author

Szegoo commented Oct 22, 2022

@ilionic PTAL.

@ilionic ilionic requested a review from HashWarlock October 22, 2022 17:49
ilionic
ilionic approved these changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@ilionic ilionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Szegoo Szegoo requested review from HashWarlock and removed request for bmacer October 31, 2022 10:04
HashWarlock
HashWarlock approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@HashWarlock HashWarlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilionic ilionic requested a review from bmacer November 1, 2022 09:22
@ilionic ilionic merged commit 1b64a15 into rmrk-team:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashWarlock HashWarlock HashWarlock approved these changes

@ilionic ilionic ilionic approved these changes

@bmacer bmacer Awaiting requested review from bmacer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equippables should handle additions/deletions (currently just overrides full list)
4 participants
@Szegoo @ilionic @bmacer @HashWarlock