Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug 229 Send/Accept NFT #230

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Fix Bug 229 Send/Accept NFT #230

merged 3 commits into from
Oct 18, 2022

Conversation

HashWarlock
Copy link
Contributor

@HashWarlock HashWarlock commented Oct 14, 2022 •
edited
Loading

Target

  • deprecate the new_owner parameter.
  • Add test & update NftInfo owner field to match uniques' owner during nft_send and nft_accept
  • Move permission checks to user facing function and use new_owner as an expected check against storage
  • Add Integration test

@HashWarlock HashWarlock requested a review from ilionic October 14, 2022 22:30
@ilionic ilionic merged commit 7abb495 into main Oct 18, 2022
@ilionic ilionic deleted the bug/229-accept-nft-bug branch October 18, 2022 12:58
@ilionic ilionic mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdovgan rdovgan rdovgan approved these changes

@ilionic ilionic ilionic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HashWarlock @ilionic @rdovgan