Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix 227 Update Children storage when sending NFT directly to NFT #228

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Bug Fix 227 Update Children storage when sending NFT directly to NFT #228

merged 2 commits into from
Oct 18, 2022

Conversation

HashWarlock
Copy link
Contributor

Fix bug #227 where minting directly to NFT does not update the Children StorageDoubleMap which cause the Children to be inconsistent.

@HashWarlock HashWarlock requested review from ilionic and bmacer October 13, 2022 22:43
ilionic
ilionic approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@ilionic ilionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests pass, LGTM.

@ilionic ilionic merged commit 44beca9 into main Oct 18, 2022
@ilionic ilionic deleted the bug/227-mint-direct-to-nft branch October 18, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdovgan rdovgan rdovgan approved these changes

@ilionic ilionic ilionic approved these changes

@bmacer bmacer Awaiting requested review from bmacer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HashWarlock @ilionic @rdovgan