Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RPC Equip/Unequip Logic #202

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Fix RPC Equip/Unequip Logic #202

merged 2 commits into from
Jul 29, 2022

Conversation

HashWarlock
Copy link
Contributor

Targets

  • Check is NFTs (item to equip & equipper NFT) exists before proceeding in do_equip
  • Change RPC functions for equip & unequip to handle errors correctly

@HashWarlock HashWarlock requested a review from ilionic July 28, 2022 22:44
ilionic
ilionic approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ilionic ilionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilionic ilionic merged commit 16173fc into rmrk-team:main Jul 29, 2022
@HashWarlock HashWarlock deleted the fix-rpc branch August 12, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilionic ilionic ilionic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashWarlock @ilionic