make owner during minting optional #171

ilionic · 2022-06-07T22:42:59Z

Fixes #160

Haven't added explicit test, but it's implicit here:

rmrk-substrate/pallets/rmrk-core/src/tests.rs

Lines 54 to 57 in c3c969c

    
           fn basic_mint() -> DispatchResult { 
        
           	RMRKCore::mint_nft( 
        
           		Origin::signed(ALICE), 
        
           		None, // if not specified defaults to minter

bmacer

LGTM

ilionic added 2 commits June 8, 2022 00:42

make owner during minting optional

37c3ccb

update tests

c3c969c

ilionic marked this pull request as ready for review June 7, 2022 22:53

ilionic requested a review from bmacer June 7, 2022 22:53

cleanup owner optionals

bb1e6e6

ilionic requested a review from HashWarlock June 8, 2022 09:36

bmacer approved these changes Jun 9, 2022

View reviewed changes

ilionic added 2 commits June 10, 2022 18:33

Merge branch 'main' into mint-optional-owner

3724be3

fix tests

655b46b

ilionic merged commit 17b6c32 into main Jun 10, 2022

ilionic deleted the mint-optional-owner branch June 10, 2022 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make owner during minting optional #171

make owner during minting optional #171

ilionic commented Jun 7, 2022 •

edited

Loading

bmacer left a comment

	fn basic_mint() -> DispatchResult {
	RMRKCore::mint_nft(
	Origin::signed(ALICE),
	None, // if not specified defaults to minter

make owner during minting optional #171

make owner during minting optional #171

Conversation

ilionic commented Jun 7, 2022 • edited Loading

bmacer left a comment

Choose a reason for hiding this comment

ilionic commented Jun 7, 2022 •

edited

Loading