Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reject so it murders Children struct too #158

Merged
merged 3 commits into from
Jun 3, 2022
Merged

fix reject so it murders Children struct too #158

merged 3 commits into from
Jun 3, 2022

Conversation

bmacer
Copy link
Contributor

@bmacer bmacer commented Jun 1, 2022

addresses #148

@bmacer bmacer requested a review from ilionic June 1, 2022 15:27
@bmacer
Copy link
Contributor Author

bmacer commented Jun 1, 2022 •
edited
Loading

Not sure why this is failing. The failure seems to have nothing to do with the code I changed. Probably will just trash the PR and try again
EDIT: figured it out, just needed to merge main. Should pass now, we'll see.

ilionic
ilionic approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@ilionic ilionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmacer bmacer merged commit 07884cb into main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilionic ilionic ilionic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmacer @ilionic