Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement changeissuer for base #126

Merged
merged 1 commit into from
May 3, 2022
Merged

implement changeissuer for base #126

merged 1 commit into from
May 3, 2022

Conversation

bmacer
Copy link
Contributor

@bmacer bmacer commented Apr 22, 2022

fixes #118

@bmacer bmacer requested review from ilionic and HashWarlock April 22, 2022 20:51
ilionic
ilionic approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@ilionic ilionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@ilionic ilionic merged commit 9a2e26e into main May 3, 2022
@ilionic ilionic deleted the bug/118-changeissuer branch May 3, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilionic ilionic ilionic approved these changes

@HashWarlock HashWarlock Awaiting requested review from HashWarlock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changeissuer only works to change collection, not base, issuer
2 participants
@bmacer @ilionic