Freeze Interpreter::Arguments instances #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturkel
reviewed
Sep 9, 2020
| end | ||
|
|
||
| resolved_arguments = resolved_arguments.merge_extras(extra_args) |
There was a problem hiding this comment.
Should we remove the special handling of field extras in the arguments function since we're no longer mutating the arguments hash for that case? Also am I correct in assuming that the field extensions case in the arguments function no longer applies since field extensions can no longer mutate the arguments hash?
There was a problem hiding this comment.
Ahh, thanks for the reminder of that. I removed some special handling in f66a7f5, does that look right to you?
jturkel
reviewed
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3004 , addresses issues described in #3003
TL;DR: it's possible to make mistakes where objects from the arguments cache are reused, even after they're modified in field-specific ways. This will make that impossible, since arguments objects can't be modified.
It could well be a breaking change, because arguments hashes won't play nicely with
.deleteanymore (as shown in updated test here, same goes for other destructive Hash methods).