Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetic data generation should output LyProX-style format #65

Closed
rmnldwg opened this issue Dec 19, 2023 · 0 comments
Closed

Synthetic data generation should output LyProX-style format #65

rmnldwg opened this issue Dec 19, 2023 · 0 comments
Assignees
@rmnldwg
Labels
1.0 release Issues to fix before 1.0 release bug Something isn't working
Milestone
version 1.0.0

Comments

@rmnldwg
Copy link
Owner

rmnldwg commented Dec 19, 2023

The models' methods to generate random, synthetic datasets still output the old data format. But the new version is supposed to in- and output data that is of the same format as what is fed into LyProX.

That should be updated.
@rmnldwg rmnldwg added bug Something isn't working 1.0 release Issues to fix before 1.0 release labels Dec 19, 2023
@rmnldwg rmnldwg added this to the version 1.0.0 milestone Dec 19, 2023
@rmnldwg rmnldwg self-assigned this Dec 19, 2023
rmnldwg added a commit that referenced this issue Dec 29, 2023
@rmnldwg
test(uni): assert format & dist of drawn patients
2818fb5 
Add a test that makes sure the unilateral method `draw_patients()`
outputs data in the LyProX format and its distribution matches the set
parameters.

Related: #65
rmnldwg added a commit that referenced this issue Dec 29, 2023
@rmnldwg
test(uni): allow larger delta for synth data dist
5bdfc68 
Related: #65
rmnldwg added a commit that referenced this issue Dec 29, 2023
@rmnldwg
test(bi): check bilateral data generation method
770bc57 
Related: #65
rmnldwg added a commit that referenced this issue Dec 29, 2023
@rmnldwg
fix(bi): update bilateral data generation method
e80eba4 
Fixes: #65
@rmnldwg rmnldwg closed this as completed in 1e125ed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmnldwg rmnldwg

Labels
1.0 release Issues to fix before 1.0 release bug Something isn't working
Projects
None yet
Milestone
version 1.0.0
Development

No branches or pull requests
1 participant
@rmnldwg