Fix broken DDNSNameserver param in RFC2136 plugin #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change to make the DDNSNameserver param optional in the RFC2136 plugin, actually disabled the ability to specify the DNS server manually, since the check to see if the param had been provided was using the wrong variable name. This forced nsupdate to always try to detect it via SOA, which could be wrong if people are using split DNS, etc.
|
Whoops. Guess I forgot to test the original functionality in addition to the changed functionality. Thanks for the fix, @gvengel. I also copied it to the Remove function as well. I'll get this merged and a new release out asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change (a2ff71c) to make the
DDNSNameserverparam optional in the RFC2136 plugin, actually disabled the ability to specify the DNS server manually, since the check to see if the param had been provided was using the wrong variable name. This forcednsupdateto always try to detect it via SOA, which could be wrong if people are using split DNS, etc.