Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with AcmeDns plugin adding names to existing certificate in 3.3.0 #140

Closed
rmbolger opened this issue Apr 30, 2019 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@rmbolger
Copy link
Owner

The revamped plugin argument handling in Posh-ACME 3.3.0 partially broke the AcmeDns plugin when running New-PACertificate with additional names when there's an existing order with the same primary name. The previously saved AcmeDns registrations are wiped and replaced by the new ones rather than being merged with them. This results in the new request requiring new CNAMES for all names in the order that don't have a cached validation. If there are any names that do have cached validations, they will subsequently break renewals when those validations expire.

@rmbolger rmbolger self-assigned this Apr 30, 2019
@rmbolger rmbolger added the bug Something isn't working label Apr 30, 2019
@rmbolger
Copy link
Owner Author

The plugin is now fixed in the dev branch. But unfortunately, users affected by the bug will still need to manually re-submit a new cert request in order to fix the underlying config. This will also mean updating the targets for CNAMES that currently exist because new registrations for each name will be needed.

The fix will go live in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant