Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZoneScope support to Windows plugin #134

Closed
dawe78 opened this issue Apr 4, 2019 · 4 comments
Closed

Add ZoneScope support to Windows plugin #134

dawe78 opened this issue Apr 4, 2019 · 4 comments
Assignees
@rmbolger
Labels
enhancement New feature or request

Comments

@dawe78
Copy link

dawe78 commented Apr 4, 2019

Is there a chance to add Split-Brain-DNS-Support in Posh-Acme for Windows DNS?

It should be easily possible by adding Parameter -ZoneScope $splitBrainZone in windows.ps1 (Line 38, Add-DnsServerResourceRecord call) and set a parameter in New-PACertificate for $splitBrainZone.

Greets...
@rmbolger
Copy link
Owner

rmbolger commented Apr 4, 2019

Hey @dawe78. Thanks for the request. It does sound like a fairly simple thing to add. I don't have an environment where I can test it though. So as long as you can test it for me, I'm happy to try and whip something up.

@rmbolger rmbolger self-assigned this Apr 4, 2019
@rmbolger rmbolger added the enhancement New feature or request label Apr 4, 2019
@rmbolger rmbolger changed the title Split-Brain-DNS support Add ZoneScope support to Windows plugin Apr 4, 2019
rmbolger added a commit that referenced this issue Apr 4, 2019
@rmbolger
added ZoneScope support to Windows plugin (#134)
ece095c
@rmbolger
Copy link
Owner

rmbolger commented Apr 4, 2019

Here you go. Download this copy of the Windows plugin, and see if that works for you. Basically, just add the WinZoneScope='blah' to your existing plugin parameters.

https://raw.githubusercontent.com/rmbolger/Posh-ACME/win-zonescope/Posh-ACME/DnsPlugins/Windows.ps1

@dawe78
Copy link
Author

dawe78 commented Apr 9, 2019

Works great for me, thanks for this quick solution!!!

@rmbolger rmbolger mentioned this issue Apr 9, 2019
Merged
rmbolger added a commit that referenced this issue Apr 9, 2019
@rmbolger
Add ZoneScope support to Windows plugin (#135)
1daff53 
* added ZoneScope support to Windows plugin (#134)
* updated readme with zone scopes info
@rmbolger
Copy link
Owner

rmbolger commented Apr 9, 2019

The change is now in the master branch pending a new release.

@rmbolger rmbolger closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmbolger rmbolger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmbolger @dawe78