Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add session name completion for SessionSave #403

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

chewcw
Copy link
Contributor

@chewcw chewcw commented Jan 31, 2025

Wonder why there is no completion for SessionSave, please close the PR if it's not relevant.

Enhance the SessionSave command by adding autocompletion functionality for
session names using the existing complete_session function. This improves
user experience by providing suggestions of available session names.
@rmagatti rmagatti requested review from cameronr and rmagatti February 1, 2025 01:24
Copy link
Collaborator

@cameronr cameronr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't thought about the use case for completion during saving but seems fine to me.

@cameronr cameronr changed the title Add session name completion for SessionSave feat: Add session name completion for SessionSave Feb 1, 2025
@cameronr cameronr merged commit 82630e2 into rmagatti:main Feb 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants