fix: #335 session_root_dir didn't have a path separator #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the rare places where I got the root dir without the separator. Since we already expanded the root dir when validating, we already know it'll be absolute so don't need to use plenary to get an absolute path later. So we can get the root dir as normal. Only showed up for *x.vim sessions because that's the only time we need to actually open the file to make sure it's not a user commands file.
Specify that the tests should load the minimal.lua config. It's a bit confusing, but calling `nvim -u mininmal.lua` loads the minimal config for starting the Plenary test harness. The test harness then starts another, nvim subprocess to actually run the test. Specifying `minimal_init` tells the test harness to not load other plugins (the minimal part) and to load the init file we pass in (which we'll use later to load Telescope for one of the tests) Also, run the test via PlenaryBustedDirectory instead of PlenaryBustedFile. This is a bit faster because it only starts the test harness process once rather than starting the harness for every spec file. Also make the args tests not require a setup so each file is independent and move them to the main directory.
Screenshots too finicky and we know that the session list had to work if we can load/delete anyway.
Prevents default session from being saved empty which could throw off the tests
|
@cameronr you've been doing great work with auto-session lately. I greatly appreciate the help. I've sent you an invite to become a collaborator in the repo. I think that'll make things easier for us going forward. Cheers! |
|
Oh awesome, thanks! |
rmagatti
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the rare places where I got the root dir without the separator. Since we already expanded the root dir when validating, we already know it'll be absolute so don't need to use plenary to get an absolute path later. So we can get the root dir as normal. Only showed up for *x.vim sessions because that's the only time we need to actually open the file to make sure it's not a user commands file.