Declare ddlFile as an output and correct option #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `ddlFile` property to be an output file, it's created by the task, otherwise the user is forced to create an empty file beforehand. Change the respective option to call the expected setter. Update the tests accordingly: - Do not create the DDL file beforehand to verify that the task does not require it; - Assert that the file has contents when the task is called with the CLI. Signed-off-by: thc202 <thc202@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=========================================
Coverage 95.68% 95.68%
Complexity 223 223
=========================================
Files 22 22
Lines 556 556
Branches 48 48
=========================================
Hits 532 532
Misses 10 10
Partials 14 14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
ddlFileproperty to be an output file, it's created by thetask, otherwise the user is forced to create an empty file beforehand.
Change the respective option to call the expected setter.
Update the tests accordingly:
not require it;
CLI.