Run pylint in pre-commit system hook #7
Conversation
.pre-commit-config.yaml
Outdated
| @@ -7,6 +7,13 @@ repos: | |||
| language: script | |||
| entry: scripts/check_commit_message | |||
| stages: [commit-msg] | |||
| - id: pylint | |||
| name: pylint | |||
| entry: python -m pylint.__main__ | |||
There was a problem hiding this comment.
does simply pylint not work?
can you provide a link to the github issue which prompted this?
There was a problem hiding this comment.
There was a problem hiding this comment.
I believe running pylint is guaranteed to work as long as it is correctly installed - it uses distutils in setup.py to setup system wide alias. So let's keep thing simple.
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 71.59% 71.59%
=======================================
Files 17 17
Lines 352 352
=======================================
Hits 252 252
Misses 100 100Continue to review full report at Codecov.
|
|
I will force commit once this is rebased. please ping me. |
`pylint` is available system wide as long as it is installed correctly (via setup.py)
naeioi
force-pushed
the
pre_commit-checks
branch
from
948ede5
to
5594cb6
Compare
|
@ryanjulian rebased. |
|
If I install |
|
@ryanjulian It works if installed by pip. I will check for conda and virtualenv to make sure. |
|
Okay, I think if it works if installed by pip then it should work in conda and virtualenv. That's the beauty of packages. |
|
Confirmed that straight |
Pre-commit runs in an isolated environment. As a result, the built-in pylint can only do static check but not dynamic import check. This PR fixs this issue by calling pylint in a pre-commit "system hook" as suggested here.