Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs-ext to 0.4.5 for iojs 2.0 compatibility. #251

Closed
wants to merge 1 commit into from

Conversation

ChALkeR
Copy link

@ChALkeR ChALkeR commented May 14, 2015

fs-ext 0.4.4 does not work with iojs 2.0 because it depends on an old version of nan.

@ChALkeR
Copy link
Author

ChALkeR commented May 16, 2015

nodejs/node#1620

@vernak2539
Copy link
Contributor

wouldn't you want to update the package.yaml and generate a new npm shrinkwrap after?

@ChALkeR
Copy link
Author

ChALkeR commented May 16, 2015

@vernak2539 package.yaml is fine as it is now.
I performed only necessary changes.

@rlidwka
Copy link
Owner

rlidwka commented May 16, 2015

I think bumping fs-ext from 0.4.4 to 0.4.5 is also a necessary change, because otherwise we'd have a nan@1.8.4 that's inconsistent with package.json requirement ~1.6 in fs-ext@0.4.4.

Anyway, I re-run shrinkwrap and committed those changes in 6b6247b , will release it in a few hours.

Thanks!

@rlidwka rlidwka closed this May 16, 2015
@ChALkeR
Copy link
Author

ChALkeR commented May 16, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants