Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WildStacker Barrel support #1171

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add WildStacker Barrel support #1171

wants to merge 4 commits into from

Conversation

Tobiti
Copy link

@Tobiti Tobiti commented Apr 28, 2019

I tryed to add WildStacker barrel support for the score generation, but I can't test It, because I don't know how to compile the plugin in IDEA.

pom.xml Outdated
@@ -92,6 +92,10 @@
<id>rlf-mvn-repo</id>
<url>https://raw.github.com/rlf/mvn-repo/master/</url>
</repository>
<repository>
Copy link
Collaborator

@Muspah Muspah Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not use local file repositories in Maven. Another issue at the moment is that anyone who hasn't bought the plugin is unable to build uSkyBlock with this dependency. It would be nice if the WildStacker developer releases a public API package to use as dependency.

We can use the rlf-mvn-repo repository on Github if necessary when WildStacker doesn't offer a repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WildStack Api is free. https://www.spigotmc.org/threads/wildstackerapi-api-for-wildstacker-2.338775/
I can remove the local repository, because I changed the dependency

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the local repository

@Tobiti
Copy link
Author

Tobiti commented Apr 29, 2019

In some days I will although add Wildstacker spawner support and EpicSpawner support

Copy link
Owner

@rlf rlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, don't use systempath, it only works on your machine. Find a maven repo that has it, or put it in your own repo.

2nd, use maven shading when relying on 3rd party code, otherwise your plugin will fail if other plugins include the same plugin in a different version.

3rd why add the location, when you have the region? And why not use the existing logic to get score based on block type?

@Tobiti
Copy link
Author

Tobiti commented May 1, 2019

  1. Im new with maven. I didn't find a repo with the wildstacker api. And systempath works only on one system, if you aren't using a relative path.

  2. I will look it up and change it.

  3. I needed the location, because I didn't found a way to get the world from the region or protectedregion. But I will change it by getting the world name from the config and compare the names as strings
    And I think I'm using the existing method, because Im adding everything to the BlockCountCollection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants