Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

stage1: Ensure ptmx device usable by non-root for all flavours. #3484

Merged
merged 4 commits into from
Feb 10, 2017
Merged

stage1: Ensure ptmx device usable by non-root for all flavours. #3484

merged 4 commits into from
Feb 10, 2017

Commits on Feb 7, 2017

  1. stage1: Ensure ptmx device usable by non-root for all flavours. 

    kvm-based stage1 flavours previously used a sym-link from /dev/ptmx to
/dev/pts/ptmx. However, the VM-based stage1's /dev/pts/ptmx device has
perms 000 meaning that non-root users could not access the device.

Determine if /dev/ptmx (or it's link target) is usable by all users and
if not recreate the device.

Fixes rkt#3252.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    45746e9 View commit details
    Browse the repository at this point in the history

  2. tests: Allow output tests to specify a regular expression. 

    Added an extra parameter to runRktAsUidGidAndCheckOutput() to specify
whether the expected string provided is a literal or a regular
expression.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    8e64062 View commit details
    Browse the repository at this point in the history

  3. tests: Show output collected by expect on regex failure. 

    Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    61f0fc8 View commit details
    Browse the repository at this point in the history

  4. Tests: Added TestDevPathsStat() to check details of pty devices. 

    The new test supports the fix for rkt#3252 by making assertions about the
pseudoterminal devices.

Change required renaming TestPathsStat() to TestProcPathsStat().

Also added helper functions runRktAsGidAndCheckREOutput() and
runRktAndCheckREOutput().

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    79df37d View commit details
    Browse the repository at this point in the history