This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Change the subnet for the default-restricted network #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents `rkt gc` from working correctly, and the directory is cleaned up automatically anyways by ctx.Cleanup
This was causing collisions with the default network, since the host-local IPAM plugin maintains separate pools per networ. Fixes rkt#3438
|
LGTM on non-flakiness |
|
May the flake gods be with us. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a collision between
defaultanddefault-restricted.Also fixes some silly issues with the network test that led to IP leaks.
Fixes #3438
Fixes #2943