This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
tests: adjust security tests for systemd v232 #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systemd (v232+) provides multiple security features which automatically set the no-new-privs bit to prevent bypass. This commit opts-out paths protection, in order to test rkt no-new-privs feature.
systemd v232 introduced an hardcoded protection for /proc/sysrq-trigger, so rkt insecure mode does not work anymore for that path. Disabling the insecure part of TestPathsWrite for now, can be re-enabled once systemd/systemd#4395 is available in stage1.
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd v232 gained some protection features both at nspawn and exec level, changing some behavior used while testing rkt insecure mode.
This PR adjusts the NoNewPrivileges check and temporarily disable the sysrq-trigger one.
Closes #3367