This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1: break down overlong property lines #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comes without any specific test, as the default seccomp whitelist/blacklist are already long enough to exercise this. Should I add more? @euank @jonboulle PTAL. This only workarounds the case where we have a set of values. A single overlong line (eg. for exec) still breaks, but we need systemd patching for that. @s-urbaniak feel free to re-milestone in case this is not fine for this release. |
|
LGTM on green. Thanks! |
s-urbaniak
approved these changes
Oct 12, 2016
This commit workarounds a systemd bug, which causes unit file to be incorrectly parsed. This is triggered by property lines longer than `LINE_MAX` (2048), which frequently occur when passing a large set of values (eg. seccomp and paths). In this case, we will now split such values across multiple lines. Reference: systemd/systemd#3302
lucab
force-pushed
the
to-upstream/break-systemd-unit-lines
branch
from
4e025a2
to
8bab5bb
Compare
|
Looks like I was too aggressive with this and broke capabilities logic. Rebased to skip those. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit workarounds a systemd bug, which causes unit file
to be incorrectly parsed.
This is triggered by property lines longer than
LINE_MAX(2048),which frequently occur when passing a large set of values (eg. seccomp
and paths).
In this case, we will now split such values across multiple lines.
Reference systemd/systemd#3302
Closes #3159