This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
trust: provide InsecureSkipTLSCheck to pubkey manager #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
We should be able to pass --insecure-options=tls option to the `rkt trust`
command. But now we can't because we test insecure tls value not from
global options but from already initialized public key manager in the
metaDiscoverPubKeyLocations():
if m.InsecureSkipTLSCheck {
insecure = insecure | discovery.InsecureTLS
}
This patch adds InsecureSkipTLSCheck to the initialization of a public
key manager structure during `rkt trust` command execution. So, the
value of the `--insecure-option=tls` will be matched and used as we
suppose.
|
ok to test |
|
LGTM. Thanks for this patch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to pass --insecure-options=tls option to the
rkt trustcommand. But now we can't because we test insecure tls value not from
global options but from already initialized public key manager in the
metaDiscoverPubKeyLocations():
if m.InsecureSkipTLSCheck {
insecure = insecure | discovery.InsecureTLS
}
This patch adds InsecureSkipTLSCheck to the initialization of a public
key manager structure during
rkt trustcommand execution. So, thevalue of the
--insecure-option=tlswill be matched and used as wesuppose.